Skip to content

Remove {f,F}orall_named_irep #5786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 26, 2021
Merged

Remove {f,F}orall_named_irep #5786

merged 1 commit into from
Jan 26, 2021

Conversation

tautschnig
Copy link
Collaborator

This was useful in the past, but with C++-11 we can use a ranged-for to
avoid the iterator altogether.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig
Remove {f,F}orall_named_irep
178a87e 
This was useful in the past, but with C++-11 we can use a ranged-for to
avoid the iterator altogether.
@tautschnig tautschnig self-assigned this Jan 25, 2021
@codecov
Copy link

codecov bot commented Jan 25, 2021 •
edited
Loading

Codecov Report

Merging #5786 (178a87e) into develop (3f41c03) will decrease coverage by 0.00%.
The diff coverage is 68.29%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5786      +/-   ##
===========================================
- Coverage    69.64%   69.64%   -0.01%     
===========================================
  Files         1248     1248              
  Lines       100916   100915       -1     
===========================================
- Hits         70286    70285       -1     
  Misses       30630    30630
Flag Coverage Δ
cproversmt2 43.36% <17.07%> (+<0.01%) ⬆️
regression 66.62% <63.41%> (-0.01%) ⬇️
unit 32.18% <34.14%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/util/irep.h 95.38% <ø> (ø)
src/util/xml_irep.cpp 25.53% <0.00%> (ø)
src/util/merge_irep.cpp 33.33% <44.44%> (ø)
src/cpp/cpp_type2name.cpp 96.36% <100.00%> (-0.07%) ⬇️
src/util/irep.cpp 97.41% <100.00%> (ø)
src/util/irep_serialization.cpp 92.39% <100.00%> (ø)
src/util/lispirep.cpp 70.00% <100.00%> (ø)
src/util/source_location.cpp 96.96% <100.00%> (ø)
src/cpp/expr2cpp.cpp 41.80% <0.00%> (-0.33%) ⬇️
src/ansi-c/ansi_c_entry_point.cpp 89.65% <0.00%> (-0.08%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f41c03...178a87e. Read the comment docs.

@tautschnig tautschnig merged commit 9d398e2 into diffblue:develop Jan 26, 2021
@tautschnig tautschnig deleted the forall-named_irep branch January 26, 2021 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterschrammel peterschrammel peterschrammel approved these changes

@chrisr-diffblue chrisr-diffblue Awaiting requested review from chrisr-diffblue

@hannes-steffenhagen-diffblue hannes-steffenhagen-diffblue Awaiting requested review from hannes-steffenhagen-diffblue

@kroening kroening Awaiting requested review from kroening kroening is a code owner

@smowton smowton Awaiting requested review from smowton

Assignees

@tautschnig tautschnig

Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tautschnig @peterschrammel